Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named algebras 2 (⚠️ breaking internals❗) #402

Merged
merged 11 commits into from
Jun 26, 2024
Merged

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Jun 26, 2024

Follow-up from #399 and #400 and last breakage of internal APIs, at least for a while ...

This does not break code that depends on public protocols like BLS signatures, KZG commitments or EVM precompiles.
It will break code that imports internals.

Changes:

  • Rename C: static Curve to Name: static Algebra. It would be weird to support Stark primes like M32, Babybear or Goldilocks with "Curve".
  • Functions to access field properties that used the curve say BLS12_381 have been replaced by functions that use the field Fp[BLS12_381], Fr[BLS12_381] instead.
    • getCurveBitwidth and getCurveOrderBitwidth replaced by Fp[BLS12_381].bits() and Fr[BLS12_381].bits()
    • Mod, getCurveOrder and fieldMod replaced by modulus
  • Shorter type names:
    • ECP_ShortW -> EC_ShortW (originally ECP == Elliptic Curve Point)
    • ECP_TwEdwards -> EC_TwEdw
  • EC Mixed Addition: madd renamed to mixedSum, msub to mixedDiff
  • low-level exports renamed and splits from curves_primitives to lowlevel_*

@mratsim mratsim merged commit b138162 into master Jun 26, 2024
12 checks passed
@mratsim mratsim deleted the named-algebras-2 branch June 26, 2024 17:31
mratsim added a commit that referenced this pull request Jul 20, 2024
mratsim added a commit that referenced this pull request Jul 20, 2024
* fix(nvidia): reorg + rename following #402

* revert towering for Fp12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant