-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named algebras 2 (⚠️ breaking internals❗) #402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rve algebraic objects like Stark fields
This was referenced Jun 27, 2024
This was referenced Jul 15, 2024
mratsim
added a commit
that referenced
this pull request
Jul 20, 2024
mratsim
added a commit
that referenced
this pull request
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #399 and #400 and last breakage of internal APIs, at least for a while ...
This does not break code that depends on public protocols like BLS signatures, KZG commitments or EVM precompiles.
It will break code that imports internals.
Changes:
C: static Curve
toName: static Algebra
. It would be weird to support Stark primes like M32, Babybear or Goldilocks with "Curve".BLS12_381
have been replaced by functions that use the fieldFp[BLS12_381]
,Fr[BLS12_381]
instead.getCurveBitwidth
andgetCurveOrderBitwidth
replaced byFp[BLS12_381].bits()
andFr[BLS12_381].bits()
Mod
,getCurveOrder
andfieldMod
replaced bymodulus
curves_primitives
tolowlevel_*